Skip to content

[v3] fix: safari support audio lang "und" in audioTrack #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2024
Merged

[v3] fix: safari support audio lang "und" in audioTrack #1454

merged 4 commits into from
Jun 13, 2024

Conversation

@peaBerberian
Copy link
Collaborator

@peaBerberian peaBerberian commented Jun 12, 2024

This is an adaptation of #1428 for our legacy v3 versions, which still get some bug fixes backported from the v4

@Florent-Bouisset @peaBerberian
fix: safari support audio lang "und" in audioTrack
15c7a8a 
In HLS with Safari, if the lang "und" (undetermined) is provided
in the HLS manifest, safari will set `audioTrack.language` to `""`
because "und" does not seems to be recognised as a lang for safari.
This commit patch this behavior by changing lang if the lang is ""
and label is "und"
@Florent-Bouisset @peaBerberian
fix
2da31b6 
Revert "fix: safari support audio lang "und" in audioTrack"

This reverts commit 7bed259.
@Florent-Bouisset @peaBerberian
update Unit tests
bd44659
@Florent-Bouisset @peaBerberian
typo
c5c5b52
@peaBerberian peaBerberian added this to the 3.33.3 milestone Jun 12, 2024
@peaBerberian peaBerberian mentioned this pull request Jun 12, 2024
Merged
Florent-Bouisset
Florent-Bouisset approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@Florent-Bouisset Florent-Bouisset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, file media_element_track_choice_manager.ts only has format change, maybe that was not needed

@peaBerberian
Copy link
Collaborator Author

peaBerberian commented Jun 13, 2024

You're right, I mainly resolved conflicts (due to prettier I guess + minor updates that have been made since there I imagine) but it ended up with only cosmetic diff.

However, I do think that having a file more up-to-date with dev might facilitate backporting in the future so I'm not against keeping the diff.

@Florent-Bouisset
Copy link
Collaborator

Florent-Bouisset commented Jun 13, 2024

You're right, I mainly resolved conflicts (due to prettier I guess + minor updates that have been made since there I imagine) but it ended up with only cosmetic diff.

However, I do think that having a file more up-to-date with dev might facilitate backporting in the future so I'm not against keeping the diff.

Ok seems good to me

@peaBerberian peaBerberian merged commit f242632 into legacy-v3 Jun 13, 2024
@peaBerberian peaBerberian deleted the fix/und-lang-declared-in-manifest-HLS-v3 branch July 26, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Florent-Bouisset Florent-Bouisset Florent-Bouisset approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.33.3

Development

Successfully merging this pull request may close these issues.

3 participants

@peaBerberian @Florent-Bouisset